Clean some code in syncscheduler.

Clean some code in syncscheduler.

BUG=90868
TEST=

[lipalani1, 2011-08-12 01:17:16]

Please review.

[tim (not reviewing), 2011-08-12 20:52:40]

http://codereview.chromium.org/7640011/diff/4001/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/sync_scheduler.cc (right):

http://codereview.chromium.org/7640011/diff/4001/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/sync_scheduler.cc:388: NOTREACHED();
a comment or << " ... " would be useful

http://codereview.chromium.org/7640011/diff/4001/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/sync_scheduler.cc:776: // pending_job etc. Also those
"one off" jobs dont need to be retried.
this comment makes it seem as though we don't want them to be reliable?  see
crbug.com/57360.

[lipalani1, 2011-08-12 21:01:47]

Addressed the comments.

http://codereview.chromium.org/7640011/diff/4001/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/sync_scheduler.cc (right):

http://codereview.chromium.org/7640011/diff/4001/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/sync_scheduler.cc:388: NOTREACHED();
On 2011/08/12 20:52:40, timsteele wrote:
> a comment or << " ... " would be useful

Done.

http://codereview.chromium.org/7640011/diff/4001/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/sync_scheduler.cc:776: // pending_job etc. Also those
"one off" jobs dont need to be retried.
So the only other command that needs to be saved is clear user data. Nudges and
configs are taken care of.
There is not enough value in retrying cleanupdisabled types if we find it was
not cleaned properly.
I have another patch for Clear user data which should take care of retrying it.
Thats why I have left it as a TODO here rather than just filling it in.
I am treating CLEAR USER DATA is not a supported feature for now. let me know
when you folks want that in and I can dust the CR and rebase it and send it
again.
On 2011/08/12 20:52:40, timsteele wrote:
> this comment makes it seem as though we don't want them to be reliable?  see
> crbug.com/57360.

[tim (not reviewing), 2011-08-12 21:23:25]

http://codereview.chromium.org/7640011/diff/4001/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/sync_scheduler.cc (right):

http://codereview.chromium.org/7640011/diff/4001/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/sync_scheduler.cc:776: // pending_job etc. Also those
"one off" jobs dont need to be retried.
On 2011/08/12 21:01:47, lipalani1 wrote:
> So the only other command that needs to be saved is clear user data. Nudges
and
> configs are taken care of.
> There is not enough value in retrying cleanupdisabled types if we find it was
> not cleaned properly.
> I have another patch for Clear user data which should take care of retrying
it.
> Thats why I have left it as a TODO here rather than just filling it in.
> I am treating CLEAR USER DATA is not a supported feature for now. let me know
> when you folks want that in and I can dust the CR and rebase it and send it
> again.
> On 2011/08/12 20:52:40, timsteele wrote:
> > this comment makes it seem as though we don't want them to be reliable?  see
> > crbug.com/57360.
> 

Hm, I'm worried what it would mean for migration if CleanupDisabled fails and we
don't retry?