Issue 7640009: [ntp4] Fix last page persist state for bookmarks page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7640009: [ntp4] Fix last page persist state for bookmarks page. (Closed)

Created:
9 years, 4 months ago by csilv

Modified:
9 years, 4 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[ntp4] Fix last page persist state for bookmarks page. BUG=90889 TEST=Select Bookmarks page in NTP4, close tab, re-open, bookmarks should be the visible page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96487

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/resources/ntp4/new_tab.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

9 years, 4 months ago (2011-08-12 00:40:28 UTC) #2

lgtm

-- Evan Stade



On Thu, Aug 11, 2011 at 5:14 PM,  <csilv@chromium.org> wrote:
> Reviewers: Evan Stade,
>
> Message:
> +estade for review
>
> Description:
> [ntp4] Fix last page persist state for bookmarks page.
>
> BUG=90889
> TEST=Select Bookmarks page in NTP4, close tab, re-open, bookmarks should be
> the
> visible page.
>
> Please review this at http://codereview.chromium.org/7640009/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/resources/ntp4/new_tab.js
>
>
> Index: chrome/browser/resources/ntp4/new_tab.js
> ===================================================================
> --- chrome/browser/resources/ntp4/new_tab.js    (revision 96482)
> +++ chrome/browser/resources/ntp4/new_tab.js    (working copy)
> @@ -388,6 +388,8 @@
>       cardSlider.selectCardByValue(mostVisitedPage);
>     else if (shownPage == templateData['apps_page_id'])
>       cardSlider.selectCardByValue(appsPages[shownPageIndex]);
> +    else if (shownPage == templateData['bookmarks_page_id'])
> +      cardSlider.selectCardByValue(bookmarksPage);
>   }
>
>   /**
>
>
>

Expand Messages | Collapse Messages