Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7448)

Unified Diff: chrome/renderer/extensions/bindings_utils.cc

Issue 7640005: Add a Print() method to bindings JS for last resort debugging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/bindings_utils.h ('k') | chrome/renderer/resources/event_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/bindings_utils.cc
diff --git a/chrome/renderer/extensions/bindings_utils.cc b/chrome/renderer/extensions/bindings_utils.cc
index 385f1c69cfc76fd2a630c74d5c2b2640e368f621..21663e429c522faaf9febfd678e45d67847542ae 100644
--- a/chrome/renderer/extensions/bindings_utils.cc
+++ b/chrome/renderer/extensions/bindings_utils.cc
@@ -4,9 +4,11 @@
#include "chrome/renderer/extensions/bindings_utils.h"
+#include "base/logging.h"
#include "base/lazy_instance.h"
#include "base/stringprintf.h"
#include "base/string_split.h"
+#include "base/string_util.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_set.h"
#include "chrome/renderer/extensions/extension_dispatcher.h"
@@ -84,6 +86,10 @@ v8::Handle<v8::FunctionTemplate>
return v8::FunctionTemplate::New(GetChromeHidden);
}
+ if (name->Equals(v8::String::New("Print"))) {
+ return v8::FunctionTemplate::New(Print);
+ }
+
return v8::Handle<v8::FunctionTemplate>();
}
@@ -110,6 +116,18 @@ v8::Handle<v8::Value> ExtensionBase::GetChromeHidden(
return hidden;
}
+v8::Handle<v8::Value> ExtensionBase::Print(const v8::Arguments& args) {
+ if (args.Length() < 1)
+ return v8::Undefined();
+
+ std::vector<std::string> components;
+ for (int i = 0; i < args.Length(); ++i)
+ components.push_back(*v8::String::Utf8Value(args[i]->ToString()));
+
+ LOG(ERROR) << JoinString(components, ',');
+ return v8::Undefined();
+}
+
ContextInfo::ContextInfo(v8::Persistent<v8::Context> context,
const std::string& extension_id,
WebKit::WebFrame* parent_frame,
« no previous file with comments | « chrome/renderer/extensions/bindings_utils.h ('k') | chrome/renderer/resources/event_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698