Issue 7640004: Gtk: Make click target of tabs match their appearance.

Issue 7640004: Gtk: Make click target of tabs match their appearance. (Closed)

Created:
9 years, 4 months ago by mattm

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, James Hawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Gtk: Make click target of tabs match their appearance. BUG=87856 TEST=See bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96674

Patch Set 2 : review changes #

Patch Set 3 : review changes #

Patch Set 4 : active_tab==NULL fix #

Total comments: 1

Patch Set 5 : single space after period #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+361 lines, -34 lines)			Patch
A	chrome/browser/ui/gtk/gtk_input_event_box.h	View	1 2 3 4	1 chunk	+57 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/gtk/gtk_input_event_box.cc	View		1 chunk	+159 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/tab_gtk.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/tab_gtk.cc	View		4 chunks	+21 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/tab_strip_gtk.h	View	1 2 3 4	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc	View	1 2 3 4	6 chunks	+36 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/tabs/tab_resources.h	View	1 2 3 4	1 chunk	+22 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/tabs/tab_resources.cc	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab.cc	View		3 chunks	+2 lines, -28 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	3 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

I don't understand the description. How did the logic change, except for the re-stacking issue? ...

9 years, 4 months ago (2011-08-11 23:41:18 UTC) #2

mattm

On 2011/08/11 23:41:18, James Hawkins wrote: > I don't understand the description. How did the ...

9 years, 4 months ago (2011-08-11 23:55:03 UTC) #3

mattm

http://codereview.chromium.org/7640004/diff/1/chrome/browser/ui/tabs/tab_resources.cc File chrome/browser/ui/tabs/tab_resources.cc (right): http://codereview.chromium.org/7640004/diff/1/chrome/browser/ui/tabs/tab_resources.cc#newcode13 chrome/browser/ui/tabs/tab_resources.cc:13: static const SkScalar kTabCapWidth = 15; On 2011/08/11 23:41:19, ...

9 years, 4 months ago (2011-08-11 23:59:46 UTC) #4

James Hawkins

LGTM with nit. http://codereview.chromium.org/7640004/diff/3017/chrome/browser/ui/tabs/tab_resources.h File chrome/browser/ui/tabs/tab_resources.h (right): http://codereview.chromium.org/7640004/diff/3017/chrome/browser/ui/tabs/tab_resources.h#newcode13 chrome/browser/ui/tabs/tab_resources.h:13: // Common resources for tab widgets. ...

9 years, 4 months ago (2011-08-12 22:08:00 UTC) #5

Change committed as 96674

Expand Messages | Collapse Messages