Issue 7640001: Fix crash with print preview and the new scrollbar code that triggered an assert in WebKit side. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7640001: Fix crash with print preview and the new scrollbar code that triggered an assert in WebKit side. ... (Closed)

Created:
9 years, 4 months ago by jam

Modified:
9 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org, dpapad

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix crash with print preview and the new scrollbar code that triggered an assert in WebKit side. The problem is that WebScrollbar is now expected to have a shorter lifetime than WebPluginContainer. So convert the NewRunnableMethod to use ScopedRunnableMethodFactory to ensure that constraint is not broken. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96494

Patch Set 1 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	webkit/plugins/ppapi/ppb_scrollbar_impl.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	webkit/plugins/ppapi/ppb_scrollbar_impl.cc	View		2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages