Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: chrome/browser/accessibility/browser_accessibility_manager_unittest.cc

Issue 7639019: Fix BrowserAccessibilityManager valgrind errors. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: use scoped_ptr Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/accessibility/browser_accessibility_manager_unittest.cc
diff --git a/chrome/browser/accessibility/browser_accessibility_manager_unittest.cc b/chrome/browser/accessibility/browser_accessibility_manager_unittest.cc
index af984924ae1ae7788dedcd4cff948e0bc52f0255..3bbc2d353714da18c3fd48e2f05e5d0bf71433da 100644
--- a/chrome/browser/accessibility/browser_accessibility_manager_unittest.cc
+++ b/chrome/browser/accessibility/browser_accessibility_manager_unittest.cc
@@ -554,12 +554,12 @@ TEST(BrowserAccessibilityManagerTest, TestMoveChildUp) {
TEST(BrowserAccessibilityManagerTest, TestCreateEmptyDocument) {
// Try creating an empty document with busy state.
- BrowserAccessibilityManager* manager =
- BrowserAccessibilityManager::CreateEmptyDocument(
- NULL,
- WebAccessibility::STATE_BUSY,
- NULL,
- new CountedBrowserAccessibilityFactory());
+ scoped_ptr<BrowserAccessibilityManager> manager;
+ manager.reset(BrowserAccessibilityManager::CreateEmptyDocument(
+ NULL,
+ WebAccessibility::STATE_BUSY,
+ NULL,
+ new CountedBrowserAccessibilityFactory()));
// Verify the root is as we expect by default.
BrowserAccessibility* root = manager->GetRoot();
@@ -625,4 +625,8 @@ TEST(BrowserAccessibilityManagerTest, TestCreateEmptyDocument) {
// Verify we don't reuse objects that have changed roles.
EXPECT_NE(acc1_2, acc2_2);
+
+ // Ensure we properly cleaned up.
+ manager.reset();
+ ASSERT_EQ(0, CountedBrowserAccessibility::global_obj_count_);
}
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698