Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 7639014: Linux: Simplify printing code and make it more reliable during shutdown. (Closed)

Created:
9 years, 4 months ago by Lei Zhang
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: Simplify printing code and make it more reliable during shutdown. BUG=84992 TEST=printing still works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -57 lines) Patch
M chrome/browser/printing/print_dialog_gtk.h View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/printing/print_dialog_gtk.cc View 5 chunks +23 lines, -46 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
While working on bug 84992, I noticed the browser would occasionally hang. Gdb says we ...
9 years, 4 months ago (2011-08-12 09:42:47 UTC) #1
vandebo (ex-Chrome)
LGTM
9 years, 4 months ago (2011-08-12 20:41:31 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-13 03:45:11 UTC) #3
Change committed as 96672

Powered by Google App Engine
This is Rietveld 408576698