Issue 7639009: Cleanup: Remove old webkit/glue/plugins/plugin_list.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7639009: Cleanup: Remove old webkit/glue/plugins/plugin_list.h (Closed)

Created:
9 years, 4 months ago by Lei Zhang

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, brettw

CC:
chromium-reviews, jam, darin-cc_chromium.org, davemoore+watch_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: Remove old webkit/glue/plugins/plugin_list.h BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96625

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -40 lines)			Patch
M	chrome/browser/chromeos/gview_request_interceptor.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/ui/npapi_test_helper.cc	View	1	2 chunks	+2 lines, -8 lines	0 comments	Download
D	webkit/glue/plugins/plugin_list.h	View	1	1 chunk	+0 lines, -31 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

This should be covered by trybots, right? I don't see this used in src/native_client/ or ...

9 years, 4 months ago (2011-08-11 23:22:34 UTC) #1

commit-bot: I haz the power

9 years, 4 months ago (2011-08-12 21:30:41 UTC) #3

Presubmit check for 7639009-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  chrome/test/ui/npapi_test_helper.cc

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Expand Messages | Collapse Messages