Issue 7639004: [ChromeOS] Always fetch oauth cooken when signing in via extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7639004: [ChromeOS] Always fetch oauth cooken when signing in via extension. (Closed)

Created:
9 years, 4 months ago by xiyuan

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, zel

CC:
chromium-reviews, nkostylev+cc_chromium.org, rharrison, davemoore+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[ChromeOS] Always fetch oauth cooken when signing in via extension. BUG=chromium-os:18701, chromium-os:18994 TEST=Verify fix for chromium-os:18701 and chromium-os:18994. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96525

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -8 lines)			Patch
M	chrome/browser/browser_main.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_performer.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View		7 chunks	+11 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_authenticator.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_authenticator.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

zel

LGTM the code looks ok, i hope you tested all cases there - including passthrough ...

9 years, 4 months ago (2011-08-11 22:11:24 UTC) #2

xiyuan

On 2011/08/11 22:11:24, zel wrote: > LGTM > > the code looks ok, i hope ...

9 years, 4 months ago (2011-08-11 22:13:21 UTC) #3

Change committed as 96525