Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: chrome/browser/ui/login/login_prompt.cc

Issue 7639002: Profiles: BROWSER_OPENED (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Same code; another round to see if flake Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tabs/pinned_tab_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/login/login_prompt.cc
diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc
index 2a2c7903032b35edce149819cb97a16e096f67b6..c4c39f254fb2d6964c8ae442ddc3482c860f9ed8 100644
--- a/chrome/browser/ui/login/login_prompt.cc
+++ b/chrome/browser/ui/login/login_prompt.cc
@@ -192,19 +192,21 @@ void LoginHandler::OnRequestCancelled() {
void LoginHandler::AddObservers() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ // This is probably OK; we need to listen to everything and we break out of
+ // the Observe() if we aren't handling the same auth_info().
registrar_.Add(this, chrome::NOTIFICATION_AUTH_SUPPLIED,
- NotificationService::AllSources());
+ NotificationService::AllBrowserContextsAndSources());
registrar_.Add(this, chrome::NOTIFICATION_AUTH_CANCELLED,
- NotificationService::AllSources());
+ NotificationService::AllBrowserContextsAndSources());
}
void LoginHandler::RemoveObservers() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
registrar_.Remove(this, chrome::NOTIFICATION_AUTH_SUPPLIED,
- NotificationService::AllSources());
+ NotificationService::AllBrowserContextsAndSources());
registrar_.Remove(this, chrome::NOTIFICATION_AUTH_CANCELLED,
- NotificationService::AllSources());
+ NotificationService::AllBrowserContextsAndSources());
DCHECK(registrar_.IsEmpty());
}
« no previous file with comments | « chrome/browser/tabs/pinned_tab_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698