Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 7639002: Profiles: BROWSER_OPENED (Closed)

Created:
9 years, 4 months ago by Elliot Glaysher
Modified:
9 years, 4 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews, cbentzel+watch_chromium.org, idana, Raghu Simha, kkania, ncarter (slow), darin-cc_chromium.org, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

Profiles: Clear all BROWSER_OPENED usage BUG=87457 TEST=none R=mirandac TBR=zea,willchan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96596

Patch Set 1 #

Patch Set 2 : Same code; another round to see if flake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/predictor_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/pinned_tab_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
Appears to be flake. Also, I've check the AUTH_* usage in login_prompt.cc, and since it's ...
9 years, 4 months ago (2011-08-12 17:46:19 UTC) #1
Miranda Callahan
On 2011/08/12 17:46:19, Elliot Glaysher wrote: > Appears to be flake. Also, I've check the ...
9 years, 4 months ago (2011-08-12 18:41:46 UTC) #2
Elliot Glaysher
9 years, 4 months ago (2011-08-12 19:31:31 UTC) #3
TBR to zea,willchan: no functional differences in those files; Equivalent of a
ToWStringHack() change. Method just means the usage has been hand verified.

Powered by Google App Engine
This is Rietveld 408576698