Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: PRESUBMIT.py

Issue 7637015: Add rules to exclude files with paths containing /test/, /tool/ and /tools/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 515f3d0af10524a0fb91edd21b73bc949c0f32c6..63c81aa07dc11ffdacaed4980f93315e2240957b 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -51,6 +51,7 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
file_inclusion_pattern = r'.+%s' % source_extensions
file_exclusion_pattern = (r'.+(_test_support|_(unit|browser|ui|perf)test)%s' %
source_extensions)
+ path_exclusion_pattern = r'.*[/\\](test|tool(s)?)[/\\].*'
base_function_pattern = r'ForTest(ing)?|for_test(ing)?'
inclusion_pattern = input_api.re.compile(r'(%s)\s*\(' % base_function_pattern)
@@ -59,8 +60,8 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
base_function_pattern, base_function_pattern))
def FilterFile(affected_file):
- black_list = ((file_exclusion_pattern, ) + _EXCLUDED_PATHS +
- input_api.DEFAULT_BLACK_LIST)
+ black_list = ((file_exclusion_pattern, path_exclusion_pattern, ) +
+ _EXCLUDED_PATHS + input_api.DEFAULT_BLACK_LIST)
return input_api.FilterSourceFile(
affected_file,
white_list=(file_inclusion_pattern, ),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698