Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 7637010: Add UMA metrics for register protocol handler, part 2. (Closed)

Created:
9 years, 4 months ago by Ilya Sherman
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Avi (use Gerrit), pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add UMA metrics for register protocol handler, part 2. BUG=92440 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96519

Patch Set 1 #

Patch Set 2 : Update a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/tools/chromeactions.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/tools/extract_actions.py View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ilya Sherman
As indicated in a comment in content/browser/user_metrics.h, the syntax requires UserMetricsAction("foo bar") to all be ...
9 years, 4 months ago (2011-08-12 03:54:01 UTC) #1
koz (OOO until 15th September)
LGTM. Thanks for fixing that up.
9 years, 4 months ago (2011-08-12 04:43:24 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-12 06:25:39 UTC) #3
Change committed as 96519

Powered by Google App Engine
This is Rietveld 408576698