File Manager: sort by date by default.

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 const EMPTY_IMAGE_URI = 'data:image/gif;base64,'
         + 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw%3D%3D';
 
 var g_slideshow_data = null;
@@ skipping 622 matching lines @@
     // Always sharing the data model between the detail/thumb views confuses
     // them.  Instead we maintain this bogus data model, and hook it up to the
     // view that is not in use.
     this.emptyDataModel_ = new cr.ui.ArrayDataModel([]);
 
     this.dataModel_ = new cr.ui.ArrayDataModel([]);
     var collator = this.collator_;
     this.dataModel_.setCompareFunction('name', function(a, b) {
       return collator.compare(a.name, b.name);
     });
-    this.dataModel_.sort('name');
+    this.dataModel_.setCompareFunction('cachedMtime_',
+                                       this.compareMtime_.bind(this));
+    this.dataModel_.setCompareFunction('cachedSize_',
+                                       this.compareSize_.bind(this));
+    this.dataModel_.sort('cachedMtime_');
     this.dataModel_.prepareSort = this.prepareSort_.bind(this);
 
     if (this.dialogType_ == FileManager.DialogType.SELECT_OPEN_FILE ||
         this.dialogType_ == FileManager.DialogType.SELECT_OPEN_FOLDER ||
         this.dialogType_ == FileManager.DialogType.SELECT_SAVEAS_FILE) {
       this.selectionModelClass_ = cr.ui.ListSingleSelectionModel;
     } else {
       this.selectionModelClass_ = cr.ui.ListSelectionModel;
     }
 
     this.initTable_();
     this.initGrid_();
 
     this.setListType(FileManager.ListType.DETAIL);
 
     this.onResize_();
     this.dialogDom_.style.opacity = '1';
 
     this.textSearchState_ = {text: '', date: new Date()};
   };
 
+  /**
+   * Compare by mtime first, then by name.
+   */
+  FileManager.prototype.compareMtime_ = function(a, b) {
+    if (a.cachedMtime_ > b.cachedMtime)
+      return 1;
+
+    if (a.cachedMtime_ < b.cachedMtime)
+      return -1;
+
+    return this.collator_.compare(a.name, b.name);
+  };
+
+  /**
+   * Compare by size first, then by name.
+   */
+  FileManager.prototype.compareSize_ = function(a, b) {
+    if (a.cachedSize_ > b.cachedSize)
+      return 1;
+
+    if (a.cachedSize_ < b.cachedSize)
+      return -1;
+
+    return this.collator_.compare(a.name, b.name);
+  };
+
   FileManager.prototype.refocus = function() {
     this.document_.querySelector('[tabindex="0"]').focus();
   };
 
   FileManager.prototype.showButter = function(message, opt_options) {
     var butter = this.document_.createElement('div');
     butter.className = 'butter-bar';
     butter.style.top = '-30px';
     this.dialogDom_.appendChild(butter);
 
@@ skipping 533 matching lines @@
 
   /**
    * Cache necessary data before a sort happens.
    *
    * This is called by the table code before a sort happens, so that we can
    * go fetch data for the sort field that we may not have yet.
    */
   FileManager.prototype.prepareSort_ = function(field, callback) {
     var cacheFunction;
 
-    if (field == 'cachedMtime_') {
+    if (field == 'name' || field == 'cachedMtime_') {
+      // Mtime is the tie-breaker for a name sort, so we need to resolve
+      // it for both mtime and name sorts.
       cacheFunction = cacheEntryDate;
     } else if (field == 'cachedSize_') {
       cacheFunction = cacheEntrySize;
     } else if (field == 'cachedIconType_') {
       cacheFunction = cacheEntryIconType;
     } else {
       callback();
       return;
     }
 
@@ skipping 1841 matching lines @@
 
     if (msg) {
       console.log('no no no');
       this.alert.show(msg, onAccept);
       return false;
     }
 
     return true;
   };
 })();