Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 7635027: Change show/hide password button image. Changed to ToggleImageButton. Added tooltip to the button. (Closed)

Created:
9 years, 4 months ago by Charlie Lee
Modified:
9 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

Change show/hide password button image. Changed to ToggleImageButton. Added tooltip to the button. BUG=chromium-os:17755 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/app/theme/network_show_password_hover.png View Binary file 0 comments Download
A chrome/app/theme/network_show_password_off.png View Binary file 0 comments Download
A chrome/app/theme/network_show_password_on.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 2 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Charlie Lee
9 years, 4 months ago (2011-08-12 19:37:05 UTC) #1
xiyuan
9 years, 4 months ago (2011-08-12 19:44:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698