Issue 7635026: Profiles: Change bookmark notifications implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7635026: Profiles: Change bookmark notifications implementation. (Closed)

Created:
9 years, 4 months ago by Elliot Glaysher

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Miranda Callahan

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Profiles: Change bookmark notifications implementation. r96049 made bookmark notifications listen to a specific profile, which meant that it would miss notifications from the incognito profile/vice versa. This changes things so we listen to all profiles and filter in Observe(). BUG=87457 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96932

Patch Set 1 #

Patch Set 2 : Unvert the part of the patch that was correct. #

Total comments: 1

Patch Set 3 : nit #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	chrome/browser/extensions/extension_bookmarks_module.cc	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download
	M	chrome/browser/ui/bookmarks/bookmark_tab_helper.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

LGTM with naming nit. http://codereview.chromium.org/7635026/diff/8/chrome/browser/extensions/extension_bookmarks_module.cc File chrome/browser/extensions/extension_bookmarks_module.cc (right): http://codereview.chromium.org/7635026/diff/8/chrome/browser/extensions/extension_bookmarks_module.cc#newcode82 chrome/browser/extensions/extension_bookmarks_module.cc:82: NotificationService::AllSources()); should be AllBrowserContextsAndSources here ...

9 years, 4 months ago (2011-08-12 19:37:03 UTC) #2

Change committed as 96932

Expand Messages | Collapse Messages