chrome/browser/extensions/extension_infobar_delegate.cc - Issue 7635019: Set Extension Infobars to have a fixed height determined by the developer (clamped to sane min an...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_infobar_delegate.cc

Issue 7635019: Set Extension Infobars to have a fixed height determined by the developer (clamped to sane min an... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_infobar_delegate.h ('k') | chrome/browser/extensions/extension_infobar_module.cc » ('j') | chrome/common/extensions/api/extension_api.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_infobar_delegate.cc

===================================================================

--- chrome/browser/extensions/extension_infobar_delegate.cc (revision 96544)

+++ chrome/browser/extensions/extension_infobar_delegate.cc (working copy)

@@ -7,6 +7,7 @@

#include "chrome/browser/extensions/extension_host.h"

#include "chrome/browser/extensions/extension_process_manager.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/tab_contents/infobar.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/extensions/extension.h"

@@ -16,7 +17,8 @@

ExtensionInfoBarDelegate::ExtensionInfoBarDelegate(Browser* browser,

TabContents* tab_contents,

const Extension* extension,

- const GURL& url)

+ const GURL& url,

+ int height)

: InfoBarDelegate(tab_contents),

observer_(NULL),

extension_(extension),

@@ -30,6 +32,11 @@

Source<Profile>(browser->profile()));

registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,

Source<Profile>(browser->profile()));

+ height_ = std::max(0, height);

+ height_ = std::min(2 * InfoBar::kDefaultBarTargetHeight, height_);

+ if (height_ == 0)

+ height_ = InfoBar::kDefaultBarTargetHeight;

}

ExtensionInfoBarDelegate::~ExtensionInfoBarDelegate() {