Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7061)

Unified Diff: chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc

Issue 7635019: Set Extension Infobars to have a fixed height determined by the developer (clamped to sane min an... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc (revision 96544)
+++ chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc (working copy)
@@ -20,7 +20,6 @@
tracker_(this),
delegate_(delegate),
view_(NULL) {
- delegate_->extension_host()->view()->SetContainer(this);
BuildWidgets();
}
@@ -57,7 +56,7 @@
Extension::EXTENSION_ICON_BITTY),
ImageLoadingTracker::DONT_CACHE);
} else {
- OnImageLoaded(NULL, icon_resource, 0); // |image|, |index|.
+ OnImageLoaded(NULL, icon_resource, 0); // |image|, ..., |index|.
Evan Stade 2011/08/16 18:35:04 this comment doesn't really help at all, I'd just
}
ExtensionHost* extension_host = delegate_->extension_host();
@@ -82,13 +81,6 @@
->SetSize(new_size);
}
-void ExtensionInfoBarGtk::OnExtensionPreferredSizeChanged(
- ExtensionViewGtk* view,
- const gfx::Size& new_size) {
- // TODO(rafaelw) - Size the InfobarGtk vertically based on the preferred size
- // of the content.
-}
-
InfoBar* ExtensionInfoBarDelegate::CreateInfoBar(TabContentsWrapper* owner) {
return new ExtensionInfoBarGtk(owner, this);
}
« no previous file with comments | « chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h ('k') | chrome/browser/ui/views/infobars/extension_infobar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698