Set Extension Infobars to have a fixed height determined by the developer (clamped to sane min an...

chrome/browser/extensions/extension_infobar_delegate.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_infobar_delegate.h"
 
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/tab_contents/infobar.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/common/notification_details.h"
 #include "content/common/notification_source.h"
 
 ExtensionInfoBarDelegate::ExtensionInfoBarDelegate(Browser* browser,
                                                    TabContents* tab_contents,
                                                    const Extension* extension,
-                                                   const GURL& url)
+                                                   const GURL& url,
+                                                   int height)
     : InfoBarDelegate(tab_contents),
       observer_(NULL),
       extension_(extension),
       closing_(false) {
   ExtensionProcessManager* manager =
       browser->profile()->GetExtensionProcessManager();
   extension_host_.reset(manager->CreateInfobarHost(url, browser));
   extension_host_->set_associated_tab_contents(tab_contents);
 
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE,
                  Source<Profile>(browser->profile()));
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,
                  Source<Profile>(browser->profile()));
+
+#if defined(TOOLKIT_VIEWS) || defined(TOOLKIT_GTK)
+  int default_height = InfoBar::kDefaultBarTargetHeight;
+#elif defined(OS_MACOSX)
+  // TODO(pkasting): Once Infobars have been ported to Mac, we can remove the
+  // ifdefs and just use the Infobar constant below.
+  int default_height = 36;
+#endif
+  height_ = std::max(0, height);
+  height_ = std::min(2 * default_height, height_);
+  if (height_ == 0)
+    height_ = default_height;
 }
 
 ExtensionInfoBarDelegate::~ExtensionInfoBarDelegate() {
   if (observer_)
     observer_->OnDelegateDeleted();
 }
 
 bool ExtensionInfoBarDelegate::EqualsDelegate(InfoBarDelegate* delegate) const {
   ExtensionInfoBarDelegate* extension_delegate =
       delegate->AsExtensionInfoBarDelegate();
@@ skipping 28 matching lines @@
                                        const NotificationDetails& details) {
   if (type == chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE) {
     if (extension_host_.get() == Details<ExtensionHost>(details).ptr())
       RemoveSelf();
   } else {
     DCHECK(type == chrome::NOTIFICATION_EXTENSION_UNLOADED);
     if (extension_ == Details<UnloadedExtensionInfo>(details)->extension)
       RemoveSelf();
   }
 }