Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1577)

Unified Diff: chrome/browser/ui/cocoa/bug_report_window_controller_unittest.mm

Issue 7635017: Fix saved screenshots for feedback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mac fix 4 Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/bug_report_window_controller.mm ('k') | chrome/browser/ui/webui/bug_report_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bug_report_window_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bug_report_window_controller_unittest.mm b/chrome/browser/ui/cocoa/bug_report_window_controller_unittest.mm
deleted file mode 100644
index 22632fdc8a4a9d16c021256ea6502d8449cf2506..0000000000000000000000000000000000000000
--- a/chrome/browser/ui/cocoa/bug_report_window_controller_unittest.mm
+++ /dev/null
@@ -1,78 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#import <Cocoa/Cocoa.h>
-
-#include "base/memory/ref_counted.h"
-#include "chrome/browser/profiles/profile.h"
-#import "chrome/browser/ui/cocoa/bug_report_window_controller.h"
-#include "chrome/test/base/testing_profile.h"
-#include "content/browser/browser_thread.h"
-#include "content/browser/renderer_host/test_render_view_host.h"
-#include "content/browser/site_instance.h"
-#include "content/browser/tab_contents/test_tab_contents.h"
-#import "testing/gtest_mac.h"
-
-namespace {
-
-class BugReportWindowControllerUnittest : public RenderViewHostTestHarness {
-};
-
-// See http://crbug.com/29019 for why it's disabled.
-TEST_F(BugReportWindowControllerUnittest, DISABLED_ReportBugWithNewTabPageOpen) {
- BrowserThread ui_thread(BrowserThread::UI, MessageLoop::current());
- // Create a "chrome://newtab" test tab. SiteInstance will be deleted when
- // tabContents is deleted.
- SiteInstance* instance =
- SiteInstance::CreateSiteInstance(profile_.get());
- TestTabContents* tabContents = new TestTabContents(profile_.get(),
- instance);
- tabContents->controller().LoadURL(GURL("chrome://newtab"),
- GURL(), PageTransition::START_PAGE);
-
- BugReportWindowController* controller = [[BugReportWindowController alloc]
- initWithTabContents:tabContents
- profile:profile_.get()];
-
- // The phishing report bug is stored at index 2 in the Report Bug dialog.
- [controller setBugTypeIndex:2];
- EXPECT_TRUE([controller isPhishingReport]);
- [controller setBugTypeIndex:1];
- EXPECT_FALSE([controller isPhishingReport]);
-
- // Make sure that the tab was correctly recorded.
- EXPECT_NSEQ(@"chrome://newtab/", [controller pageURL]);
- EXPECT_NSEQ(@"New Tab", [controller pageTitle]);
-
- // When we call "report bug" with non-empty tab contents, all menu options
- // should be available, and we should send screenshot by default.
- EXPECT_EQ([[controller bugTypeList] count], 8U);
- EXPECT_TRUE([controller sendScreenshot]);
-
- delete tabContents;
- [controller release];
-}
-
-// See http://crbug.com/29019 for why it's disabled.
-TEST_F(BugReportWindowControllerUnittest, DISABLED_ReportBugWithNoWindowOpen) {
- BugReportWindowController* controller = [[BugReportWindowController alloc]
- initWithTabContents:NULL
- profile:profile_.get()];
-
- // Make sure that no page title or URL are recorded. Note that IB reports
- // empty textfields as NULL values.
- EXPECT_FALSE([controller pageURL]);
- EXPECT_FALSE([controller pageTitle]);
-
- // When we call "report bug" with empty tab contents, only menu options
- // that don't refer to a specific page should be available, and the send
- // screenshot option should be turned off.
- EXPECT_EQ([[controller bugTypeList] count], 4U);
- EXPECT_FALSE([controller sendScreenshot]);
-
- [controller release];
-}
-
-} // namespace
-
« no previous file with comments | « chrome/browser/ui/cocoa/bug_report_window_controller.mm ('k') | chrome/browser/ui/webui/bug_report_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698