Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 7635011: Pipe "is pinned to left/right", "has horizontal/vertical scrollbar", (Closed)

Created:
9 years, 4 months ago by Nico
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam
Visibility:
Public.

Description

Pipe "is pinned to left/right", "has horizontal/vertical scrollbar", "number of wheel handlers" to browser process. We want to implement two-finger-swipe for history like safari does on os x lion. The way this works is: * If a page has no horizontal scrollbars, or the page is all the way to the left, scrolling to the left will go back in history instead. * Same for right/forward. Hence, this data needs to be available in the browser process. This is modelled after the WebKit2 functions WKPageIsPinnedToLeftSide(), WKPageIsPinnedToRightSide(), WKPageHasHorizontalScrollbar(), and webPageProxy::willHandleHorizontalScrollEvents(). Depends on https://bugs.webkit.org/show_bug.cgi?id=66094 BUG=90228 TEST=No observable effect yet Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96670

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : nits #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -0 lines) Patch
M content/browser/renderer_host/render_view_host.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
M content/renderer/render_view.h View 1 2 3 chunks +15 lines, -0 lines 0 comments Download
M content/renderer/render_view.cc View 1 2 3 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
9 years, 4 months ago (2011-08-12 00:18:57 UTC) #1
jam
http://codereview.chromium.org/7635011/diff/1001/content/renderer/render_view.h File content/renderer/render_view.h (right): http://codereview.chromium.org/7635011/diff/1001/content/renderer/render_view.h#newcode562 content/renderer/render_view.h:562: virtual void numberOfWheelEventHandlersChanged(unsigned numHandlers); nit: num_handlers http://codereview.chromium.org/7635011/diff/1001/content/renderer/render_view.h#newcode563 content/renderer/render_view.h:563: virtual ...
9 years, 4 months ago (2011-08-12 17:32:25 UTC) #2
Nico
http://codereview.chromium.org/7635011/diff/1001/content/renderer/render_view.h File content/renderer/render_view.h (right): http://codereview.chromium.org/7635011/diff/1001/content/renderer/render_view.h#newcode562 content/renderer/render_view.h:562: virtual void numberOfWheelEventHandlersChanged(unsigned numHandlers); On 2011/08/12 17:32:26, John Abd-El-Malek ...
9 years, 4 months ago (2011-08-12 17:37:49 UTC) #3
jam
lgtm
9 years, 4 months ago (2011-08-12 21:03:09 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-13 03:44:34 UTC) #5
Change committed as 96670

Powered by Google App Engine
This is Rietveld 408576698