Issue 7634028: Only check the keycode for key events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7634028: Only check the keycode for key events. (Closed)

Created:
9 years, 4 months ago by dominich

Modified:
9 years, 4 months ago

Reviewers:
Mark Mentovai, commit-bot: I haz the power, Peter Kasting

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Only check the keycode for key events. Allows the re-enabling of BrowserAccelerators test. BUG=92563 TEST=*BrowserAccelerators Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96671

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/omnibox/omnibox_view_browsertest.cc	View		1 chunk	+1 line, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

dominich

The error I was seeing was related to keyCode being called on an NSEvent of ...

9 years, 4 months ago (2011-08-12 19:03:44 UTC) #1

Peter Kasting

Mark's review is both necessary and sufficient here.

9 years, 4 months ago (2011-08-12 20:30:37 UTC) #3

Change committed as 96671