Issue 7634013: Minor cleanup to UsageTracker.IsWorking().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7634013: Minor cleanup to UsageTracker.IsWorking(). (Closed)

Created:
9 years, 4 months ago by michaeln

Modified:
9 years, 4 months ago

Reviewers:
Dai Mikurube (NOT FULLTIME)

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Minor cleanup to UsageTracker.IsWorking(). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96583

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -17 lines)			Patch
M	webkit/quota/quota_manager.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/quota/quota_types.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/quota/usage_tracker.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	webkit/quota/usage_tracker.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

michaeln

Hi Dai, I noticed that the return value of IsWorking() was counter intuitively reversed. It ...

9 years, 4 months ago (2011-08-12 00:10:10 UTC) #1

Dai Mikurube (NOT FULLTIME)

9 years, 4 months ago (2011-08-12 04:22:57 UTC) #2

Ah, sure.  LGTM.  Thank you!

On 2011/08/12 00:10:10, michaeln wrote:
> Hi Dai,
> 
> I noticed that the return value of IsWorking() was counter intuitively
reversed.
> It was returning false when the class was actually doing something and true
when
> not. Then i noticed that the loop wasn't really needed.

Expand Messages | Collapse Messages