Issue 7634002: sync: more DEPS fun

Issue 7634002: sync: more DEPS fun (Closed)

Created:
9 years, 4 months ago by tim (not reviewing)

Modified:
9 years, 4 months ago

Reviewers:
akalin

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

sync: more DEPS fun Hopefully this isn't too draconian. BUG=19878 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96573

Patch Set 2 : tweak notifier #

Total comments: 1

Patch Set 4 : typo #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -23 lines)			Patch
A	chrome/browser/sync/api/DEPS	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/DEPS	View		1 chunk	+10 lines, -4 lines	0 comments	Download
A	chrome/browser/sync/glue/DEPS	View	1 2 3	1 chunk	+33 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/app_model_associator.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/bookmark_model_associator.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/change_processor_mock.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/extension_model_associator.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/generic_change_processor.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	chrome/browser/sync/js/DEPS	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/notifier/DEPS	View	1 2	1 chunk	+11 lines, -2 lines	0 comments	Download
A	chrome/browser/sync/protocol/DEPS	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/sessions/DEPS	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/syncable/DEPS	View		1 chunk	+4 lines, -6 lines	0 comments	Download
A	chrome/browser/sync/util/DEPS	View	1 2 3	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

akalin

http://codereview.chromium.org/7634002/diff/3016/chrome/browser/sync/notifier/DEPS File chrome/browser/sync/notifier/DEPS (left): http://codereview.chromium.org/7634002/diff/3016/chrome/browser/sync/notifier/DEPS#oldcode5 chrome/browser/sync/notifier/DEPS:5: "+jingle/notifier", I think this is still needed? p2p_notifier.cc #includes ...

9 years, 4 months ago (2011-08-11 21:52:27 UTC) #2

tim (not reviewing)

On 2011/08/11 21:52:27, akalin wrote: > http://codereview.chromium.org/7634002/diff/3016/chrome/browser/sync/notifier/DEPS > File chrome/browser/sync/notifier/DEPS (left): > > http://codereview.chromium.org/7634002/diff/3016/chrome/browser/sync/notifier/DEPS#oldcode5 > ...

9 years, 4 months ago (2011-08-11 21:58:39 UTC) #3

akalin

It's not third-party, though, the jingle/ top-level directory is chrome code that glues to the ...

9 years, 4 months ago (2011-08-11 22:09:00 UTC) #4

akalin

On 2011/08/12 17:19:01, timsteele wrote: > I added jingle/notifier back in. Did you figure out ...

9 years, 4 months ago (2011-08-12 17:24:08 UTC) #6

tim (not reviewing)

On 2011/08/12 17:24:08, akalin wrote: > On 2011/08/12 17:19:01, timsteele wrote: > > I added ...

9 years, 4 months ago (2011-08-12 17:26:21 UTC) #7

akalin

9 years, 4 months ago (2011-08-12 17:33:21 UTC) #8

LGTM

http://codereview.chromium.org/7634002/diff/4016/chrome/browser/sync/util/DEPS
File chrome/browser/sync/util/DEPS (right):

http://codereview.chromium.org/7634002/diff/4016/chrome/browser/sync/util/DEP...
chrome/browser/sync/util/DEPS:9: # this file is wierd.
weird

Expand Messages | Collapse Messages