Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 7633078: Pull system_api.git. (Closed)

Created:
9 years, 4 months ago by satorux1
Modified:
9 years, 4 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, pam+watch_chromium.org, DaveMoore
Visibility:
Public.

Description

Pull system_api.git. system_api.git will be used to share constants and definitions between Chrome and Chrome OS. BUG=chromium-os:19054 TEST=confirm that third_party/cros and third_party/system_api are pulled Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96857

Patch Set 1 #

Patch Set 2 : update .gitignore #

Total comments: 2

Patch Set 3 : Rename directory name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M .gitignore View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/cros.DEPS/DEPS View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
satorux1
9 years, 4 months ago (2011-08-15 22:18:26 UTC) #1
Daniel Erat
/third_party/system_api should be added to .gitignore in this change, right?
9 years, 4 months ago (2011-08-15 22:27:44 UTC) #2
satorux1
On 2011/08/15 22:27:44, Daniel Erat wrote: > /third_party/system_api should be added to .gitignore in this ...
9 years, 4 months ago (2011-08-15 22:38:43 UTC) #3
Daniel Erat
+dave in case he has an opinion http://codereview.chromium.org/7633078/diff/3001/.gitignore File .gitignore (right): http://codereview.chromium.org/7633078/diff/3001/.gitignore#newcode138 .gitignore:138: /third_party/system_api Hmm, ...
9 years, 4 months ago (2011-08-15 22:44:09 UTC) #4
satorux1
http://codereview.chromium.org/7633078/diff/3001/.gitignore File .gitignore (right): http://codereview.chromium.org/7633078/diff/3001/.gitignore#newcode138 .gitignore:138: /third_party/system_api On 2011/08/15 22:44:09, Daniel Erat wrote: > Hmm, ...
9 years, 4 months ago (2011-08-15 23:00:50 UTC) #5
Daniel Erat
9 years, 4 months ago (2011-08-15 23:02:44 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698