chrome/browser/sync/syncable/syncable.cc - Issue 7633077: Refactor syncapi.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/syncable/syncable.cc

Issue 7633077: Refactor syncapi.h (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Set of patches to refactor syncapi.h Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/internal_api/syncapi_functions.cc ('K') | « chrome/browser/sync/sync_setup_wizard_unittest.cc ('k') | chrome/browser/sync/test_profile_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/syncable/syncable.cc

diff --git a/chrome/browser/sync/syncable/syncable.cc b/chrome/browser/sync/syncable/syncable.cc

index cf30b99af14e15d35b3115702d14afb807870a8f..0977039351268983efeb4283f270efcb86cf1541 100644

--- a/chrome/browser/sync/syncable/syncable.cc

+++ b/chrome/browser/sync/syncable/syncable.cc

@@ -27,28 +27,29 @@

#include <set>

#include <string>

-#include "base/hash_tables.h"

#include "base/file_util.h"

+#include "base/hash_tables.h"

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

#include "base/perftimer.h"

+#include "base/stl_util.h"

#include "base/string_number_conversions.h"

#include "base/string_util.h"

-#include "base/stl_util.h"

#include "base/time.h"

#include "base/tracked.h"

#include "base/utf_string_conversions.h"

#include "base/values.h"

+#include "chrome/browser/sync/internal_api/read_transaction.h"

tim (not reviewing) 2011/08/16 20:08:03 hrm... this looks odd. internal_api::ReadTransact

rlarocque 2011/08/16 22:19:19 Done. (both removing the include and adding a DEP

#include "chrome/browser/sync/protocol/proto_value_conversions.h"

#include "chrome/browser/sync/protocol/service_constants.h"

#include "chrome/browser/sync/syncable/directory_backing_store.h"

#include "chrome/browser/sync/syncable/directory_change_delegate.h"

#include "chrome/browser/sync/syncable/directory_manager.h"

#include "chrome/browser/sync/syncable/model_type.h"

-#include "chrome/browser/sync/syncable/syncable-inl.h"

#include "chrome/browser/sync/syncable/syncable_changes_version.h"

#include "chrome/browser/sync/syncable/syncable_columns.h"

#include "chrome/browser/sync/syncable/syncable_enum_conversions.h"

+#include "chrome/browser/sync/syncable/syncable-inl.h"

#include "chrome/browser/sync/syncable/transaction_observer.h"

#include "chrome/browser/sync/util/logging.h"

#include "net/base/escape.h"