Refactor syncapi.h

chrome/browser/sync/engine/read_transaction.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYNC_ENGINE_READ_TRANSACTION_H_
+#define CHROME_BROWSER_SYNC_ENGINE_READ_TRANSACTION_H_
+
+#include "chrome/browser/sync/engine/base_transaction.h"
+
+namespace tracked_objects {
+class Location;
+}  // namespace tracked_objects

[tim (not reviewing), 2011/08/15 22:53:55]

Well, you can remove this since it is inline below... 

[rlarocque, 2011/08/16 18:12:46]

Remove the forward declaration?  I don't see how that would work.

On 2011/08/15 22:53:55, timsteele wrote:

+
+namespace sync_api {
+
+class UserShare;
+
+// TODO(akalin): Make ReadTransaction/WriteTransaction take a Location
+// parameter.

[tim (not reviewing), 2011/08/15 22:53:55]

Think you can remove this todo.

[rlarocque, 2011/08/16 18:12:46]

Done.

+
+// Sync API's ReadTransaction is a read-only BaseTransaction.  It wraps
+// a syncable::ReadTransaction.
+class ReadTransaction : public BaseTransaction {
+ public:
+  // Start a new read-only transaction on the specified repository.
+  ReadTransaction(const tracked_objects::Location& from_here,
+                  UserShare* share);
+
+  // Resume the middle of a transaction. Will not close transaction.
+  ReadTransaction(UserShare* share, syncable::BaseTransaction* trans);
+
+  virtual ~ReadTransaction();
+
+  // BaseTransaction override.
+  virtual syncable::BaseTransaction* GetWrappedTrans() const;
+ private:
+  void* operator new(size_t size);  // Transaction is meant for stack use only.
+
+  // The underlying syncable object which this class wraps.
+  syncable::BaseTransaction* transaction_;
+  bool close_transaction_;
+
+  DISALLOW_COPY_AND_ASSIGN(ReadTransaction);
+};
+
+} // namespace sync_api

[tim (not reviewing), 2011/08/15 22:53:55]

Perhaps we should change this to be 
browser_sync::internal_api once it lives in the internal_api folder?

[rlarocque, 2011/08/16 18:12:46]

I was thinking about that, but then I figured this merge will be hard enough as
is.  Maybe we can open another ticket for it.  

On 2011/08/15 22:53:55, timsteele wrote:

+
+#endif  // CHROME_BROWSER_SYNC_ENGINE_READ_TRANSACTION_H_