Issue 7633076: Allow GraphicsContext3D to be created with a NULL WebView for offscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7633076: Allow GraphicsContext3D to be created with a NULL WebView for offscreen (Closed)

Created:
9 years, 4 months ago by Stephen White

Modified:
9 years, 4 months ago

Reviewers:
Ken Russell (switch to Gerrit), greggman

CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Allow GraphicsContext3D to be created with a NULL WebView for offscreen contexts. This makes it easier to enable GPU acceleration from a lower level in WebKit. Also allow the in-process implementation of glTexImage2D() to take a NULL pixels ptr. It's semantically valid in GL, and the command buffer implementation already seems to handle it fine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96940

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/gpu/webgraphicscontext3d_in_process_impl.cc	View		4 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

LGTM Do you need to modify src/content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc ?

9 years, 4 months ago (2011-08-15 22:14:39 UTC) #2

Stephen White

On 2011/08/15 22:14:39, kbr wrote: > LGTM > > Do you need to modify > ...

9 years, 4 months ago (2011-08-15 22:22:51 UTC) #3

lgtm

Expand Messages | Collapse Messages