Issue 7633063: Fix a bug that was preventing rapid tab closure from working on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7633063: Fix a bug that was preventing rapid tab closure from working on Mac. (Closed)

Created:
9 years, 4 months ago by rohitrao (ping after 24h)

Modified:
9 years, 4 months ago

Reviewers:
Robert Sesek, commit-bot: I haz the power

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix a bug that was preventing rapid tab closure from working on Mac. Fixes a tab strip layout bug where closing tabs would not properly position the close button under the mouse cursor. BUG=92623 TEST=Open incognito window and create many tabs. Try to close the rightmost tab. The tabs should reposition so that the close button is under the mouse. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96928

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...

9 years, 4 months ago (2011-08-15 21:00:33 UTC) #3

Change committed as 96928

Expand Messages | Collapse Messages