Issue 7633046: Fix VPN icon issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7633046: Fix VPN icon issues (Closed)

Created:
9 years, 4 months ago by stevenjb

Modified:
9 years, 4 months ago

Reviewers:
Charlie Lee

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix VPN icon issues Includes other small fixes discovered while testing: * Alignment of provider type text for configured VPN connect UI. * Open conenct dialog on any VPN connect failure BUG=chromium-os:17161, chromium-os:18670 TEST=Test network icons in in the statu bar, network menu, and internet options page with VPN disconnected, conencting, and connected, and with diferent underlying networks connected (ethernet, wifi, cellular, none). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96967

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -35 lines)			Patch
M	chrome/browser/chromeos/cros/cros_mock.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View	1 2	2 chunks	+22 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/network_login_observer.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/options/vpn_config_view.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View	1	3 chunks	+11 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_icon.cc	View		3 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 7633046: Fix VPN icon issues (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Fix mock expectations. #

Messages