Issue 7633045: Fix scaling calculation.

Issue 7633045: Fix scaling calculation. (Closed)

Created:
9 years, 4 months ago by Lambros

Modified:
9 years, 4 months ago

Reviewers:
Wez, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix scaling calculation. BUG=92343 TEST=Verify scale-to-fit works with fat,narrow + tall,thin windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96823

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reset scale to 1.0 instead of bailing out early. #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -10 lines)			Patch
	M	remoting/webapp/me2mom/client_session.js	View	1	2 chunks	+5 lines, -10 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Wez

http://codereview.chromium.org/7633045/diff/1/remoting/webapp/me2mom/client_session.js File remoting/webapp/me2mom/client_session.js (right): http://codereview.chromium.org/7633045/diff/1/remoting/webapp/me2mom/client_session.js#newcode390 remoting/webapp/me2mom/client_session.js:390: remoting.debug.log('scale up is not supported'); Don't we need to ...

9 years, 4 months ago (2011-08-13 01:38:50 UTC) #2

Lambros

Also made logging a bit nicer. http://codereview.chromium.org/7633045/diff/1/remoting/webapp/me2mom/client_session.js File remoting/webapp/me2mom/client_session.js (right): http://codereview.chromium.org/7633045/diff/1/remoting/webapp/me2mom/client_session.js#newcode390 remoting/webapp/me2mom/client_session.js:390: remoting.debug.log('scale up is ...

9 years, 4 months ago (2011-08-13 02:13:30 UTC) #3

Jamie

LGTM with one comment. http://codereview.chromium.org/7633045/diff/4/remoting/webapp/me2mom/client_session.js File remoting/webapp/me2mom/client_session.js (right): http://codereview.chromium.org/7633045/diff/4/remoting/webapp/me2mom/client_session.js#newcode385 remoting/webapp/me2mom/client_session.js:385: var scaleFitWidth = 1.0 * ...

9 years, 4 months ago (2011-08-13 02:24:51 UTC) #4

Lambros

9 years, 4 months ago (2011-08-15 20:03:45 UTC) #5

http://codereview.chromium.org/7633045/diff/4/remoting/webapp/me2mom/client_s...
File remoting/webapp/me2mom/client_session.js (right):

http://codereview.chromium.org/7633045/diff/4/remoting/webapp/me2mom/client_s...
remoting/webapp/me2mom/client_session.js:385: var scaleFitWidth = 1.0 * width /
this.plugin.desktopWidth;
On 2011/08/13 02:24:51, Jamie wrote:
> I'd be tempted to guard against either width or height being zero.
Already covered by line 370, I think?

Expand Messages | Collapse Messages