Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 7633032: Revert 96593 - Fix up various browser tests not to use WaitForNavigation. (Closed)

Created:
9 years, 4 months ago by Greg Billock
Modified:
9 years, 4 months ago
Reviewers:
Greg Billock
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 96593 - Fix up various browser tests not to use WaitForNavigation. Convenience methods for WindowedNotificationObserver. R=phajdan.jr@chromium.org BUG=various TEST=none Review URL: http://codereview.chromium.org/7489019 TBR=gbillock@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -192 lines) Patch
M chrome/browser/browser_focus_uitest.cc View 4 chunks +7 lines, -32 lines 0 comments Download
M chrome/browser/crash_recovery_browsertest.cc View 4 chunks +10 lines, -15 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +5 lines, -11 lines 0 comments Download
M chrome/browser/pdf_browsertest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/sidebar/sidebar_browsertest.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 11 chunks +48 lines, -105 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 4 chunks +7 lines, -15 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Greg Billock
9 years, 4 months ago (2011-08-12 21:05:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698