Remove extension.h #include from profile.h.

Remove extension.h #include from profile.h.

Touching extension.h now results in 202 files being compiled instead of 495 (when
building the chrome target). Required that the UnloadedExtensionReason enum be
moved to extension_constants.h.

R=asargent@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96686

[asargent_no_longer_on_chrome, 2011-08-12 21:00:41]

LGTM, nice savings

http://codereview.chromium.org/7633029/diff/2002/chrome/browser/extensions/ap...
File chrome/browser/extensions/app_process_apitest.cc (right):

http://codereview.chromium.org/7633029/diff/2002/chrome/browser/extensions/ap...
chrome/browser/extensions/app_process_apitest.cc:13: #include
"chrome/common/extensions/extension.h"
"Include what you use, yo!"

[commit-bot: I haz the power, 2011-08-12 22:23:44]

Presubmit check for 7633029-2002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/profiles/profile_impl.h,chrome/browser/profiles/profile.h,chrome/browser/profiles/profile_impl.cc,chrome/browser/sync/glue/app_change_processor.cc,chrome/browser/sync/glue/extension_change_processor.cc

Presubmit checks took 1.4s to calculate.

[Mihai Parparita -not on Chrome, 2011-08-12 22:27:32]

Miranda or Elliot: could you LGTM for profiles?
Fred: could you LGM for sync?

Thanks,
Mihai

On 2011/08/12 22:23:44, I haz the power (commit-bot) wrote:
> Presubmit check for 7633029-2002 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> If this change has an associated bug, add BUG=[bug number].
> 
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for:
>
chrome/browser/profiles/profile_impl.h,chrome/browser/profiles/profile.h,chrome/browser/profiles/profile_impl.cc,chrome/browser/sync/glue/app_change_processor.cc,chrome/browser/sync/glue/extension_change_processor.cc
> 
> Presubmit checks took 1.4s to calculate.

[Elliot Glaysher, 2011-08-12 22:33:57]

Datatype change in profile LGTM.

(Also thanks for shrinking header dependencies!)

[akalin, 2011-08-12 22:51:50]

On 2011/08/12 22:33:57, Elliot Glaysher wrote:
> Datatype change in profile LGTM.
> 
> (Also thanks for shrinking header dependencies!)

noiiiiiice

sync changes LGTM

[commit-bot: I haz the power, 2011-08-13 05:31:02]

Change committed as 96686