Issue 7633023: Add feedback link to sad tab for killed pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7633023: Add feedback link to sad tab for killed pages. (Closed)

Created:
9 years, 4 months ago by stevenjb

Modified:
9 years, 4 months ago

Reviewers:
James Cook

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add feedback link to sad tab for killed pages. BUG=chromium-os:18720 TEST=Go to chrome://kill to kill a tab. There should be a feedback link which should navigate to the feedback page and populate the message field with "Chrome ran out of memory." Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97000

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -7 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+6 lines, -0 lines	1 comment	Download
M	chrome/browser/ui/views/sad_tab_view.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/sad_tab_view.cc	View	6 chunks	+43 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Cook

LGTM with one optional nit http://codereview.chromium.org/7633023/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7633023/diff/1/chrome/app/generated_resources.grd#newcode7222 chrome/app/generated_resources.grd:7222: Chrome ran out of ...

9 years, 4 months ago (2011-08-12 21:38:02 UTC) #2

stevenjb

9 years, 4 months ago (2011-08-12 22:46:05 UTC) #3

On 2011/08/12 21:38:02, James Cook (Chromium) wrote:
> LGTM with one optional nit
> 
>
http://codereview.chromium.org/7633023/diff/1/chrome/app/generated_resources.grd
> File chrome/app/generated_resources.grd (right):
> 
>
http://codereview.chromium.org/7633023/diff/1/chrome/app/generated_resources....
> chrome/app/generated_resources.grd:7222: Chrome ran out of memory.\n
> Does this need a \n, or can you add it in the code?  I'm not sure if the
> translators will know what to do with that.

I checked that we use \n in other messages, so there is precedent.

Expand Messages | Collapse Messages