Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: webkit/fileapi/sandbox_mount_point_provider_unittest.cc

Issue 7633016: Test cleanup: Using MockSpecialStoragePolicy instead of local subclasses of SpecialStoragePolicy. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Oops, cleaning up leftover TestSpecialStoragePolicy classes. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/sandbox_mount_point_provider_unittest.cc
diff --git a/webkit/fileapi/sandbox_mount_point_provider_unittest.cc b/webkit/fileapi/sandbox_mount_point_provider_unittest.cc
index 511a01365bbaf42bf467d36da00becaa220a81aa..39e9463fcdf4ec734a26dcf3a49caa9b5e497089 100644
--- a/webkit/fileapi/sandbox_mount_point_provider_unittest.cc
+++ b/webkit/fileapi/sandbox_mount_point_provider_unittest.cc
@@ -22,6 +22,7 @@
#include "webkit/fileapi/file_system_operation_context.h"
#include "webkit/fileapi/file_system_path_manager.h"
#include "webkit/fileapi/file_system_util.h"
+#include "webkit/quota/mock_special_storage_policy.h"
namespace fileapi {
@@ -127,27 +128,6 @@ const MigrationTestCaseRecord kMigrationTestRecords[] = {
{ GURL("file:///"), false, true },
};
-class TestSpecialStoragePolicy : public quota::SpecialStoragePolicy {
- public:
- explicit TestSpecialStoragePolicy(bool unlimited_quota)
- : unlimited_quota_(unlimited_quota) {}
-
- virtual bool IsStorageProtected(const GURL& origin) {
- return false;
- }
-
- virtual bool IsStorageUnlimited(const GURL& origin) {
- return unlimited_quota_;
- }
-
- virtual bool IsFileHandler(const std::string& extension_id) {
- return true;
- }
-
- private:
- bool unlimited_quota_;
-};
-
} // anonymous namespace
class SandboxMountPointProviderMigrationTest : public testing::Test {
@@ -163,7 +143,7 @@ class SandboxMountPointProviderMigrationTest : public testing::Test {
file_system_context_ = new FileSystemContext(
base::MessageLoopProxy::CreateForCurrentThread(),
base::MessageLoopProxy::CreateForCurrentThread(),
- new TestSpecialStoragePolicy(true /* unlimited quota */),
marja 2011/08/16 10:54:25 I changed this to use the "all unlimited" mode of
+ new quota::MockSpecialStoragePolicy,
NULL,
data_dir_.path(),
false, // incognito

Powered by Google App Engine
This is Rietveld 408576698