Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: webkit/fileapi/file_system_path_manager_unittest.cc

Issue 7633016: Test cleanup: Using MockSpecialStoragePolicy instead of local subclasses of SpecialStoragePolicy. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Oops, cleaning up leftover TestSpecialStoragePolicy classes. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/file_system_path_manager_unittest.cc
diff --git a/webkit/fileapi/file_system_path_manager_unittest.cc b/webkit/fileapi/file_system_path_manager_unittest.cc
index 122487e6967b47101c7a6306a8fbf840f5279e75..05a96a0a92fd7d13553dab8519d5a2d2053c2ea1 100644
--- a/webkit/fileapi/file_system_path_manager_unittest.cc
+++ b/webkit/fileapi/file_system_path_manager_unittest.cc
@@ -21,7 +21,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "webkit/fileapi/file_system_util.h"
#include "webkit/fileapi/sandbox_mount_point_provider.h"
-#include "webkit/quota/special_storage_policy.h"
+#include "webkit/quota/mock_special_storage_policy.h"
namespace fileapi {
namespace {
@@ -205,21 +205,6 @@ FilePath UTF8ToFilePath(const std::string& str) {
return FilePath(result);
}
-class TestSpecialStoragePolicy : public quota::SpecialStoragePolicy {
- public:
- virtual bool IsStorageProtected(const GURL& origin) {
- return false;
- }
-
- virtual bool IsStorageUnlimited(const GURL& origin) {
marja 2011/08/16 10:54:25 IsStorageUnlimited & IsFileHandler here were never
- return true;
- }
-
- virtual bool IsFileHandler(const std::string& extension_id) {
- return true;
- }
-};
-
} // namespace
class FileSystemPathManagerTest : public testing::Test {
@@ -243,7 +228,7 @@ class FileSystemPathManagerTest : public testing::Test {
base::MessageLoopProxy::CreateForCurrentThread(),
data_dir_.path(),
scoped_refptr<quota::SpecialStoragePolicy>(
- new TestSpecialStoragePolicy()),
+ new quota::MockSpecialStoragePolicy),
incognito,
allow_file_access);
#if defined(OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698