Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: webkit/fileapi/file_system_test_helper.cc

Issue 7633016: Test cleanup: Using MockSpecialStoragePolicy instead of local subclasses of SpecialStoragePolicy. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Keeping up to date with trunk. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/file_system_test_helper.cc
diff --git a/webkit/fileapi/file_system_test_helper.cc b/webkit/fileapi/file_system_test_helper.cc
index 535ad769e3257625941509477f3259cd8f9a7c59..3748f861425a03fcfd04e87f7352a03ce555b896 100644
--- a/webkit/fileapi/file_system_test_helper.cc
+++ b/webkit/fileapi/file_system_test_helper.cc
@@ -14,33 +14,9 @@
#include "webkit/fileapi/file_system_usage_cache.h"
#include "webkit/fileapi/file_system_util.h"
#include "webkit/fileapi/sandbox_mount_point_provider.h"
-#include "webkit/quota/special_storage_policy.h"
+#include "webkit/quota/mock_special_storage_policy.h"
namespace fileapi {
-namespace {
-
-class TestSpecialStoragePolicy : public quota::SpecialStoragePolicy {
- public:
- explicit TestSpecialStoragePolicy(bool unlimited_quota)
- : unlimited_quota_(unlimited_quota) {}
-
- virtual bool IsStorageProtected(const GURL& origin) {
- return false;
- }
-
- virtual bool IsStorageUnlimited(const GURL& origin) {
- return unlimited_quota_;
- }
-
- virtual bool IsFileHandler(const std::string& extension_id) {
- return true;
- }
-
- private:
- bool unlimited_quota_;
-};
-
-} // anonymous namespace
FileSystemTestOriginHelper::FileSystemTestOriginHelper(
const GURL& origin, FileSystemType type)
@@ -93,10 +69,13 @@ void FileSystemTestOriginHelper::SetUp(
FileSystemFileUtil* file_util) {
file_util_ = file_util;
DCHECK(file_util_);
+ scoped_refptr<quota::MockSpecialStoragePolicy> special_storage_policy =
+ new quota::MockSpecialStoragePolicy;
+ special_storage_policy->SetAllUnlimited(unlimited_quota);
file_system_context_ = new FileSystemContext(
base::MessageLoopProxy::current(),
base::MessageLoopProxy::current(),
- new TestSpecialStoragePolicy(unlimited_quota),
+ special_storage_policy,
quota_manager_proxy,
base_dir,
incognito_mode,
« no previous file with comments | « webkit/fileapi/file_system_path_manager_unittest.cc ('k') | webkit/fileapi/file_system_url_request_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698