Do not use deprecated ARM instructions in DirectCEntryStub::GenerateCall.

src/arm/deoptimizer-arm.cc

Index: src/arm/deoptimizer-arm.cc
===================================================================
--- src/arm/deoptimizer-arm.cc	(revision 8912)
+++ src/arm/deoptimizer-arm.cc	(working copy)
@@ -593,6 +593,8 @@
   __ vstm(db_w, sp, first, last);
 
   // Push all 16 registers (needed to populate FrameDescription::registers_).
+  // TODO(1588) Note that using pc with stm is deprecated, so we should perhaps
+  // handle this a bit differently.

[m.m.capewell, 2011/08/12 11:50:54]

The ARM ARM also deprecates using sp in an stm. Additionally, it says
"Instructions with the base register in the list and ! specified [...] the use
of such instructions is deprecated. If the base register is not the
lowest-numbered register in the list, such an instruction stores an UNKNOWN
value for the base register."
Thus, if restored_regs is populated, the updated sp is UNKNOWN. In practice,
this seems to work, but it may break in new ARM implementations.
Perhaps add some debug code to check the sp stored on the stack is as expected?

   __ stm(db_w, sp, restored_regs  | sp.bit() | lr.bit() | pc.bit());
 
   const int kSavedRegistersAreaSize =