Do not use deprecated ARM instructions in DirectCEntryStub::GenerateCall.

src/arm/deoptimizer-arm.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 575 matching lines @@
       (DwVfpRegister::kNumAllocatableRegisters - 1));
 #ifdef DEBUG
   for (int i = 0; i <= (DwVfpRegister::kNumAllocatableRegisters - 1); i++) {
     ASSERT((DwVfpRegister::FromAllocationIndex(i).code() <= last.code()) &&
            (DwVfpRegister::FromAllocationIndex(i).code() >= first.code()));
   }
 #endif
   __ vstm(db_w, sp, first, last);
 
   // Push all 16 registers (needed to populate FrameDescription::registers_).
+  // TODO(1588) Note that using pc with stm is deprecated, so we should perhaps
+  // handle this a bit differently.

[m.m.capewell, 2011/08/12 11:50:54]

The ARM ARM also deprecates using sp in an stm. Additionally, it says
"Instructions with the base register in the list and ! specified [...] the use
of such instructions is deprecated. If the base register is not the
lowest-numbered register in the list, such an instruction stores an UNKNOWN
value for the base register."
Thus, if restored_regs is populated, the updated sp is UNKNOWN. In practice,
this seems to work, but it may break in new ARM implementations.
Perhaps add some debug code to check the sp stored on the stack is as expected?

   __ stm(db_w, sp, restored_regs  | sp.bit() | lr.bit() | pc.bit());
 
   const int kSavedRegistersAreaSize =
       (kNumberOfRegisters * kPointerSize) + kDoubleRegsSize;
 
   // Get the bailout id from the stack.
   __ ldr(r2, MemOperand(sp, kSavedRegistersAreaSize));
 
   // Get the address of the location in the code object if possible (r3) (return
   // address for lazy deoptimization) and compute the fp-to-sp delta in
@@ skipping 157 matching lines @@
     __ push(ip);
     __ b(&done);
     ASSERT(masm()->pc_offset() - start == table_entry_size_);
   }
   __ bind(&done);
 }
 
 #undef __
 
 } }  // namespace v8::internal