Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 7633012: Unbreak SSL/TLS preferences (Closed)

Created:
9 years, 4 months ago by Ilya Sherman
Modified:
9 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Unbreak SSL/TLS preferences Revert part of http://codereview.chromium.org/7314020/. It turns out that these preferences are stored in local state rather than the user state, and the ability to bind a checkbox to a preference currently only works for user preferences. Local state preferences needs to be done manually. BUG=92448 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -7 lines) Patch
M chrome/browser/resources/options/advanced_options.html View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.js View 2 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.cc View 5 chunks +70 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ilya Sherman
9 years, 4 months ago (2011-08-12 03:42:21 UTC) #1
csilv
LGTM
9 years, 4 months ago (2011-08-12 06:31:19 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-12 08:09:58 UTC) #3
Change committed as 96529

Powered by Google App Engine
This is Rietveld 408576698