First stab at webinputevent_linux.cc. Coverts GDK events to

First stab at webinputevent_linux.cc.  Coverts GDK events to
our webkit glue classes.

[darin (slow to review), 2008-10-21 23:31:06]

perhaps webinputevent_gtk.cc would be a better name?

http://codereview.chromium.org/7633/diff/605/607
File webkit/glue/event_conversion.cc (right):

http://codereview.chromium.org/7633/diff/605/607#newcode13
Line 13: #include "third_party/WebKit/WebCore/platform/gtk/KeyboardCodes.h"
so this will end up being used in the mac port too?  i guess that is ok.  hmm...

(i bet the right answer is to move this file to a shared location upstream.)

http://codereview.chromium.org/7633/diff/605/609
File webkit/glue/webinputevent_linux.cc (right):

http://codereview.chromium.org/7633/diff/605/609#newcode20
Line 20: using namespace WebCore;
nit: should follow google style here which says not to do a using directive like
this.  you can do "using WebCore::Foo;" though.

http://codereview.chromium.org/7633/diff/605/609#newcode45
Line 45: // WebKit/WebCore/platform/gtk/KeyEventGtk.cpp
hmm... i'm starting to think that we should break this (and the one in
event_conversion.cc) out into separate files so that the licensing is more
clear.  it'd also pave the way to maybe sharing these case-switch statements
with the other webkit ports.

[tony, 2008-10-22 21:22:21]

On 2008/10/21 23:31:06, darin wrote:
> perhaps webinputevent_gtk.cc would be a better name?

I was trying to follow the convention in base where we use linux even if we mean
gtk or gdk.

> http://codereview.chromium.org/7633/diff/605/607
> File webkit/glue/event_conversion.cc (right):
> 
> http://codereview.chromium.org/7633/diff/605/607#newcode13
> Line 13: #include "third_party/WebKit/WebCore/platform/gtk/KeyboardCodes.h"
> so this will end up being used in the mac port too?  i guess that is ok. 
hmm...
> 
> (i bet the right answer is to move this file to a shared location upstream.)

I've just copied this file into webkit/port/platform/chromium.  This seems to be
what the other platforms are doing (there's a copy in platform/gtk, platform/qt,
platform/wx).

> http://codereview.chromium.org/7633/diff/605/609
> File webkit/glue/webinputevent_linux.cc (right):
> 
> http://codereview.chromium.org/7633/diff/605/609#newcode20
> Line 20: using namespace WebCore;
> nit: should follow google style here which says not to do a using directive
like
> this.  you can do "using WebCore::Foo;" though.

Removed the using WebCore; line.

> http://codereview.chromium.org/7633/diff/605/609#newcode45
> Line 45: // WebKit/WebCore/platform/gtk/KeyEventGtk.cpp
> hmm... i'm starting to think that we should break this (and the one in
> event_conversion.cc) out into separate files so that the licensing is more
> clear.  it'd also pave the way to maybe sharing these case-switch statements
> with the other webkit ports.

Ok, I pulled it out into it's own .h and .cpp file in
webkit/port/platform/chromium/KeyCodeConversion.h (so we can share with mac) and
webkit/port/platform/chromium/KeyCodeConversionGtk.cpp.

Take another look?

[darin (slow to review), 2008-10-23 19:19:07]

LGTM