Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7631063: Prefix all IPC messages used by src\chrome with Chrome. For e.g ChromeViewMsg_, ChromeViewHostMsg... (Closed)

Created:
9 years, 4 months ago by ananta
Modified:
9 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, Avi (use Gerrit), jam, tburkard+watch_chromium.org, kkania, Erik does not do reviews, brettw-cc_chromium.org, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, cbentzel+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org, native-client-reviews_googlegroups.com, mmenke
Visibility:
Public.

Description

Prefix all IPC messages used by src\chrome with Chrome. For e.g ChromeViewMsg_, ChromeViewHostMsg, etc. This makes it easier to identify which messages are specific to content and chrome. This is a preparation CL for bug http://code.google.com/p/chromium/issues/detail?id=87335 which requires IPC's to not span across content and chrome. When IPC's cross these boundaries they need to be handled as API calls. BUG=87335 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97536

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -364 lines) Patch
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/image_decoder.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/memory_menu_button.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_webstore_private_api.cc View 1 2 3 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 2 3 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/memory_purger.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/field_trial_synchronizer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/histogram_synchronizer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_observer.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_render_view_host_observer.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 3 3 chunks +23 lines, -19 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/web_cache_manager.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_state_message_filter.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/insecure_content_infobar_delegate.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 3 17 chunks +34 lines, -31 lines 0 comments Download
M chrome/browser/translate/translate_tab_helper.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_test_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/visitedlink/visitedlink_event_listener.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 2 3 4 chunks +23 lines, -23 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 3 14 chunks +69 lines, -68 lines 0 comments Download
M chrome/renderer/automation/dom_automation_controller.cc View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/renderer/blocked_plugin.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_ppapi_interfaces.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 2 3 6 chunks +22 lines, -18 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 2 3 10 chunks +17 lines, -16 lines 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/renderer/content_settings_observer_browsertest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/external_extension.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/external_host_bindings.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/net/renderer_net_predictor.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/prerender/prerender_helper.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_histogram_snapshots.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox.cc View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/renderer/translate_helper.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/translate_helper_browsertest.cc View 1 2 3 6 chunks +14 lines, -14 lines 0 comments Download
M chrome/renderer/visitedlink_slave.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 2 3 4 chunks +16 lines, -13 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 1 2 3 10 chunks +31 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 4 months ago (2011-08-19 01:04:28 UTC) #1
jam
9 years, 4 months ago (2011-08-19 19:59:43 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698