src/v8natives.js - Issue 7631039: Use InternalArray in Object.defineProperties to avoid issues with overwriten properties on Array....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 7631039: Use InternalArray in Object.defineProperties to avoid issues with overwriten properties on Array.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8natives.js

===================================================================

--- src/v8natives.js (revision 8946)

+++ src/v8natives.js (working copy)

@@ -1020,7 +1020,7 @@

if (!IS_SPEC_OBJECT(obj))

throw MakeTypeError("obj_ctor_property_non_object", ["defineProperties"]);

var props = ToObject(properties);

- var key_values = [];

+ var key_values = new InternalArray();

for (var key in props) {

Lasse Reichstein 2011/08/18 06:56:41 How about making a way to find all own properties

if (%HasLocalProperty(props, key)) {

key_values.push(key);

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-1625.js » ('j') | no next file with comments »