Use InternalArray in Object.defineProperties to avoid issues with overwriten properties on Array....

Use InternalArray in Object.defineProperties to avoid issues with overwriten properties on Array.prototype

TEST=mjsunit/regress/regress-1625
BUG=v8:1625
Committed: http://code.google.com/p/v8/source/detail?r=8964

[Lasse Reichstein, 2011-08-18 06:56:41]

LGTM

http://codereview.chromium.org/7631039/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/7631039/diff/1/src/v8natives.js#newcode1024
src/v8natives.js:1024: for (var key in props) {
How about making a way to find all own properties only? E.g.
something like GetOwnPropertyNames that filter the non-enumerable out?

[Rico, 2011-08-18 08:32:10]

please have another look, refactored the function

[Lasse Reichstein, 2011-08-18 08:35:22]

LGTM

http://codereview.chromium.org/7631039/diff/6/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/7631039/diff/6/src/v8natives.js#newcode1018
src/v8natives.js:1018: function GetOwnPropertyNames(properties) {
Put "Enuerable" in the name somewhere.

http://codereview.chromium.org/7631039/diff/6/src/v8natives.js#newcode1020
src/v8natives.js:1020: for (var key in properties) {
I was hoping there would be a way to get the own property names without getting
all inherited properties and then discarding hem again. But this is a good
refactoring to start with.

http://codereview.chromium.org/7631039/diff/6/src/v8natives.js#newcode1021
src/v8natives.js:1021: global.print("key: " + key);
Without the prints? :)