Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 7631027: Multi-Profiles: Add profile avatar if second profile is added (Closed)

Created:
9 years, 4 months ago by sail
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Multi-Profiles: Add profile avatar if second profile is added When adding a new profile existing windows wouldn't update to show the profile avatar icon. The problem was that we were only adding the avatar on window creation. Fix was to check to see if we should add the avatar when the profile info cache changes. Note, when adding or removing the avatar we layout the entire window frame. This is more than necessary but it's not a big deal since new profiles are not added very often. BUG=92740 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M chrome/browser/profiles/profile_info_cache.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 3 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sail
mirandac: profile stuff pkasting: view stuff
9 years, 4 months ago (2011-08-17 20:56:50 UTC) #1
Peter Kasting
LGTM, feel free to check with ben or sky if you want to know if ...
9 years, 4 months ago (2011-08-17 21:02:02 UTC) #2
sail
erg, mind looking at the profiles change?
9 years, 4 months ago (2011-08-17 21:23:35 UTC) #3
Elliot Glaysher
On 2011/08/17 21:23:35, sail wrote: > erg, mind looking at the profiles change? Profile change ...
9 years, 4 months ago (2011-08-17 21:26:45 UTC) #4
commit-bot: I haz the power
Change committed as 97241
9 years, 4 months ago (2011-08-17 23:58:30 UTC) #5
Miranda Callahan
On 2011/08/17 23:58:30, I haz the power (commit-bot) wrote: > Change committed as 97241 post ...
9 years, 4 months ago (2011-08-18 07:35:49 UTC) #6
sail
9 years, 4 months ago (2011-08-18 16:57:10 UTC) #7
On 2011/08/18 07:35:49, Miranda Callahan wrote:
> On 2011/08/17 23:58:30, I haz the power (commit-bot) wrote:
> > Change committed as 97241
> 
> post hoc LGTM -- but doesn't this also need a change in the
> glass_browser_frame_view as well?

Yep, only realized this when I got home :-P Working on this now.

Powered by Google App Engine
This is Rietveld 408576698