Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/test/webdriver/session.h

Issue 7629019: Revert 96556 - Let pyauto create an attached webdriver instance to manipulate web pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/commands/create_session.cc ('k') | chrome/test/webdriver/session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/session.h
===================================================================
--- chrome/test/webdriver/session.h (revision 96579)
+++ chrome/test/webdriver/session.h (working copy)
@@ -79,7 +79,9 @@
// It |user_data_dir| is empty, it will use a temporary dir.
// Returns true on success. On failure, the session will delete
// itself and return an error code.
- Error* Init(const Automation::BrowserOptions& options);
+ Error* Init(const FilePath& browser_exe,
+ const FilePath& user_data_dir,
+ const CommandLine& options);
// Should be called before executing a command. Performs necessary waits
// and frame switching.
@@ -327,7 +329,9 @@
void RunSessionTaskOnSessionThread(
Task* task,
base::WaitableEvent* done_event);
- void InitOnSessionThread(const Automation::BrowserOptions& options,
+ void InitOnSessionThread(const FilePath& browser_exe,
+ const FilePath& user_data_dir,
+ const CommandLine& options,
Error** error);
void TerminateOnSessionThread();
« no previous file with comments | « chrome/test/webdriver/commands/create_session.cc ('k') | chrome/test/webdriver/session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698