webkit/plugins/ppapi/ppb_surface_3d_impl.cc - Issue 7629017: Add a unified resource tracker shared between the proxy and the impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppb_surface_3d_impl.cc

Issue 7629017: Add a unified resource tracker shared between the proxy and the impl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/ppb_surface_3d_impl.cc

diff --git a/webkit/plugins/ppapi/ppb_surface_3d_impl.cc b/webkit/plugins/ppapi/ppb_surface_3d_impl.cc

index 81d761f25d45e176964048d447a696f55db1dd53..fe2651475aeecffb3accf444d600f1d564d076b4 100644

--- a/webkit/plugins/ppapi/ppb_surface_3d_impl.cc

+++ b/webkit/plugins/ppapi/ppb_surface_3d_impl.cc

@@ -71,10 +71,8 @@ int32_t PPB_Surface3D_Impl::SwapBuffers(PP_CompletionCallback callback) {

if (!context_)

return PP_ERROR_FAILED;

- PP_Resource resource_id = GetReferenceNoAddRef();

- CHECK(resource_id);

swap_callback_ = new TrackedCompletionCallback(

- instance()->module()->GetCallbackTracker(), resource_id, callback);

+ instance()->module()->GetCallbackTracker(), pp_resource(), callback);

gpu::gles2::GLES2Implementation* impl = context_->gles2_impl();

if (impl)

context_->gles2_impl()->SwapBuffers();