Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: webkit/plugins/ppapi/ppb_file_system_impl.cc

Issue 7629017: Add a unified resource tracker shared between the proxy and the impl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/ppb_file_system_impl.cc
diff --git a/webkit/plugins/ppapi/ppb_file_system_impl.cc b/webkit/plugins/ppapi/ppb_file_system_impl.cc
index 9ba9b3f2bb525a387a445149ac4d555aa3bc0698..2a4bb05f7876e52ecc6d0e5bfc4d023d886c6216 100644
--- a/webkit/plugins/ppapi/ppb_file_system_impl.cc
+++ b/webkit/plugins/ppapi/ppb_file_system_impl.cc
@@ -46,9 +46,7 @@ PP_Resource PPB_FileSystem_Impl::Create(PluginInstance* instance,
type != PP_FILESYSTEMTYPE_LOCALPERSISTENT &&
type != PP_FILESYSTEMTYPE_LOCALTEMPORARY)
return 0;
-
- PPB_FileSystem_Impl* file_system = new PPB_FileSystem_Impl(instance, type);
- return file_system->GetReference();
+ return (new PPB_FileSystem_Impl(instance, type))->GetReference();
}
PPB_FileSystem_API* PPB_FileSystem_Impl::AsPPB_FileSystem_API() {
@@ -74,8 +72,7 @@ int32_t PPB_FileSystem_Impl::Open(int64_t expected_size,
instance()->container()->element().document().url(),
file_system_type, expected_size,
new FileCallbacks(instance()->module()->AsWeakPtr(),
- GetReferenceNoAddRef(),
- callback, NULL,
+ pp_resource(), callback, NULL,
scoped_refptr<PPB_FileSystem_Impl>(this), NULL)))
return PP_ERROR_FAILED;
return PP_OK_COMPLETIONPENDING;

Powered by Google App Engine
This is Rietveld 408576698