webkit/plugins/ppapi/ppb_file_io_impl.cc - Issue 7629017: Add a unified resource tracker shared between the proxy and the impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppb_file_io_impl.cc

Issue 7629017: Add a unified resource tracker shared between the proxy and the impl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/ppb_file_io_impl.cc

diff --git a/webkit/plugins/ppapi/ppb_file_io_impl.cc b/webkit/plugins/ppapi/ppb_file_io_impl.cc

index 5ac35b2b742abe6cad3a11ffa3dacd16f0012ec2..63021fa95ca1743c04a185a39996f490642f7e40 100644

--- a/webkit/plugins/ppapi/ppb_file_io_impl.cc

+++ b/webkit/plugins/ppapi/ppb_file_io_impl.cc

@@ -314,10 +314,8 @@ void PPB_FileIO_Impl::RegisterCallback(OperationType op,

(pending_op_ != OPERATION_EXCLUSIVE && pending_op_ == op));

CallbackEntry entry;

- PP_Resource resource_id = GetReferenceNoAddRef();

- CHECK(resource_id);

entry.callback = new TrackedCompletionCallback(

- instance()->module()->GetCallbackTracker(), resource_id, callback);

+ instance()->module()->GetCallbackTracker(), pp_resource(), callback);

entry.read_buffer = read_buffer;

callbacks_.push(entry);