Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.cc

Issue 7629017: Add a unified resource tracker shared between the proxy and the impl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/ppapi_plugin_instance.cc
diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.cc b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
index 4af282964089a370ba2635308dab0c66ea00b8dc..e1c714f780ddccc9ae4f0672fe527097125510be 100644
--- a/webkit/plugins/ppapi/ppapi_plugin_instance.cc
+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
@@ -454,7 +454,6 @@ bool PluginInstance::HandleInputEvent(const WebKit::WebInputEvent& event,
CreateInputEventData(event, &events);
// Each input event may generate more than one PP_InputEvent.
- ResourceTracker* tracker = ResourceTracker::Get();
for (size_t i = 0; i < events.size(); i++) {
if (filtered_input_event_mask_ & event_class)
events[i].is_filtered = true;
@@ -462,13 +461,10 @@ bool PluginInstance::HandleInputEvent(const WebKit::WebInputEvent& event,
rv = true; // Unfiltered events are assumed to be handled.
scoped_refptr<PPB_InputEvent_Impl> event_resource(
new PPB_InputEvent_Impl(this, events[i]));
- PP_Resource resource = event_resource->GetReference();
+ Resource::ScopedResourceId resource_id(event_resource.get());
rv |= PP_ToBool(plugin_input_event_interface_->HandleInputEvent(
- pp_instance(), event_resource->GetReference()));
-
- // Release the reference we took above.
- tracker->UnrefResource(resource);
+ pp_instance(), resource_id.id));
}
}
}

Powered by Google App Engine
This is Rietveld 408576698